Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update url used for querying patchnotes #178

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

TheEpicBlock
Copy link
Contributor

@TheEpicBlock TheEpicBlock commented Jan 31, 2024


See preview on Cloudflare Pages: https://preview-178.quiltmc-org.pages.dev

@ix0rai ix0rai added the bug Something isn't working label Jan 31, 2024
@TheEpicBlock
Copy link
Contributor Author

TheEpicBlock commented Feb 1, 2024

The v1 api was generally order correctly (at least for recent versions, older ones were completely messed up, see 1.13). The v2 api however lists snapshots before release versions. That's why I pulled in the meta to achieve a proper ordering. This is probably what the launcher does too

@Southpaw1496
Copy link
Contributor

Are there any other differences between V1 and V2 that are relevant to our purposes?

@TheEpicBlock
Copy link
Contributor Author

TheEpicBlock commented Feb 1, 2024

Nothing major, at least not in patchnote part.

The index file no longer contains the changelogs of each version ever published, those are in separate jsons now (specified by contentPath in the index). The code here has already been changed to handle that.

Note that the url for the separate json files is relative to https://launchercontent.mojang.com/v2/, but the urls for the images are still relative to https://launchercontent.mojang.com

@ghost
Copy link

ghost commented Feb 1, 2024

I mean if you approve the workflow, we could easily check if anything else changed lol

@Pyrofab Pyrofab merged commit df17795 into QuiltMC:main Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants