Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when intermediary has not released #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IotaBread
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jan 31, 2024

This PR has two main issues:

  1. The installer will most likely error out in inexplicable ways because of some 404s, this needs to be properly handled.
  2. There is nothing retriggering the build once either intermediary or hashed is published, this needs to be either automatic or at least properly warn (using a Discord webhook or so) the developers so they can watch and manually retrigger a build once they're published

@IotaBread
Copy link
Member Author

IotaBread commented Feb 10, 2024

The installer will most likely error out in inexplicable ways because of some 404s

How about not listing Minecraft versions without intermediary?

There is nothing retriggering the build once either intermediary or hashed is published

I'm not sure about how that would be fixed here, and it's already a problem without this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant