Readme config addition; Fix hopper flags mixin; Added ability for trusted players to break chests (configurable) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds config that will allow trusted players of a chest to break the chest This defaults to false as it makes most sense to retain current behavior by default
Added config section to readme
In my testing hopper flags just did not work. The getInventoryAt() seems to be no longer reliable as a mixin to prevent hopper accessing the chests Injecting and canceling a specific one of the 3 HopperBlockEntity extract methods seems to stop hoppers properly, although, it only stops the hoppers from extracting from a locked and flagged chest while it still is able to insert into any chest logged/flagged or not
you cannot comment out lines in a json. Though if u were to comment them out it would just be deleted, its not a good thing to encourage.
PotatoPresident
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the mixin for HopperBlockEntity which, at least in my testing, was not actually preventing hoppers from siphoning from containers locked and flagged false for hoppers.
I also added the ability in the config to allow trusted players to break chests instead of just the owner per
#22
#31
This is set to false by default currently as I did not want to change expected behavior.
I also added a section for config to the readme.