Use single threaded coroutine context for database transactions #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some concurrency issues (eg. Rollbacks failing to write to the database during high load)
yqs112358
added a commit
to YQ-Fabric-Mods/Ledger
that referenced
this pull request
Aug 7, 2024
3 tasks
Use default dispatcher for non-io concurrency Don't try to drain empty queue
PotatoPresident
approved these changes
Aug 15, 2024
3 tasks
|
When merge? Very needed change. |
|
When would this be in an release, had this issue on 1.21.1? Thanks for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some concurrency issues (eg. Rollbacks failing to write to the database during high load) by using a single thread thread pool.
SQLite won't benefit from using multiple connections from the same process anyways. Other databases might(?) benefit in some cases, but likely not a lot, because Ledger is all about writing to pretty much one table.