Fix for issue #57 #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd just adds overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #57 Can't filter for "Hot". The issue was basically that, when navigating to a subreddit, the id getting passed into the
.Navigate(...)method was always "funnyHotWeek" (assuming you're navigating to /r/funny). If you had switched the default sort type in your settings (to "new" in this case), the panel would behave as if it was "funnyNewWeek". When you would then go to change the sort to "hot", the.Navigate(...)method would think that you're trying to go from "funnyHotWeek" to "funnyHotWeek" and it would basically do nothing, if that makes sense.There might be a cleaner way to do it. There's probably not really a need to pass in the sort arguments in both of those places that were changed, since they would end up as the default anyway, so I can always reverse that if need be.
I merged master into the develop branch. I can always reverse that merge to separate just my changes if that works better.
Let me know! Thanks!