Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yozu julia cache #132

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Yozu julia cache #132

merged 3 commits into from
Jun 23, 2023

Conversation

yasuo-ozu
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-132--quri-parts.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 21, 2023 10:56 Inactive
kwkbtr
kwkbtr reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@kwkbtr kwkbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to use in the cache key a unique value like a hash of a project file, since the same cache will be used forever otherwise.
(It would not be a big problem, though, given that our Julia dependencies don't change much)

@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 14:28 Inactive
@kwkbtr kwkbtr merged commit e1027f6 into main Jun 23, 2023
@kwkbtr kwkbtr deleted the yozu_julia_cache branch June 23, 2023 02:12
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwkbtr kwkbtr kwkbtr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasuo-ozu @kwkbtr