Kupccgsd identify parameter #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-185--quri-parts.netlify.app |
|
Can you write some comments in the PR description if there are breaking changes? (e.g. number/order of parameters etc.) (By the way, #181 is already merged but could you add comments about breaking changes there too?) |
|
I just added comments on this PR page and the PR page for the UCCSD |
kwkbtr
reviewed
Aug 1, 2023
| @@ -55,53 +60,142 @@ def __init__( | |||
| fermion_qubit_mapping: OpenFermionQubitMapping = jordan_wigner, | |||
| trotter_number: int = 1, | |||
| delta_sz: int = 0, | |||
| singlet_excitation: bool = False, | |||
There was a problem hiding this comment.
Can you add docstring for singlet_excitation?
There was a problem hiding this comment.
I just added the docstring for it
kwkbtr
reviewed
Aug 1, 2023
kwkbtr
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify particular parameters in kupgccsd ansatz