Allow to pass keyword arguments to itensor mps estimator for fast computation. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
Sure, leave it to me! |
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
terasakisatoshi
commented
Sep 1, 2023
…ensor_mps_sampler`
terasakisatoshi
commented
Sep 1, 2023
Of course we can pass `mindim` as long as ITensors.apply supports it internally.
…that create a concurrent estimator
…ncurrent_sampler`
Done. Ready for review 🙏 |
toru4838
reviewed
Sep 19, 2023
add `.` Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
toru4838
requested changes
Sep 25, 2023
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
toru4838
reviewed
Sep 26, 2023
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
toru4838
reviewed
Sep 27, 2023
Co-authored-by: Toru Shibamiya <49753430+toru4838@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to pass keyword arguments to
jl.applyin the auxiliary function _estimate. Note thatjl.applyJulia function ITensors.apply. By passingmaxdim, it enables us to calculate the expectation value at high speed by obtaining the Truncated SVD in ITensors.factorize and svd. These functions are called from theITensors.apply.