Bug fix in conversion of PauliNoise to Qulacs #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lqtmirage
commented
Dec 12, 2024
lqtmirage
commented
- Fixed a bug in the conversion of PauliNoise to Qulacs
- Add a test case
- Stop adding an Identity gate to make the sum of probability of the Probabilistic gate for PauliNoise to 1 since current Qulacs does not seem to require that
|
🚀 Deployed on https://deploy-preview-392--quri-parts.netlify.app |
|
Is this identical to the PR in the internal repo? If so I will approve it |
|
Yes, this is a public repository version of the PR to the internal repository. Thank you for approval. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.