Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectivity graph #70

Merged
merged 3 commits into from
May 15, 2023
Merged

Connectivity graph #70

merged 3 commits into from
May 15, 2023

Conversation

Zshan0
Copy link
Contributor

@Zshan0 Zshan0 commented Apr 14, 2023

Functionality for accessing connectivity graph from IBM backend. Since accessing the actual hardware without gaining a subscription is impossible, I have created tests that fake the hardware responses.

@Zshan0 Zshan0 requested a review from kwkbtr April 14, 2023 14:06
@github-actions
Copy link

github-actions bot commented Apr 14, 2023

🚀 Deployed on https://deploy-preview-70--quri-parts.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 14:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 28, 2023 18:49 Inactive
@Zshan0 Zshan0 requested a review from kwkbtr April 28, 2023 18:51
Copy link
Contributor

@kwkbtr kwkbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested tiny improvements but I think it's good to go!

@github-actions github-actions bot temporarily deployed to pull request May 12, 2023 14:02 Inactive
@Zshan0
Copy link
Contributor Author

Zshan0 commented May 12, 2023

I have made the necessary changes and the tests are passing, if appropriate please merge it

@kwkbtr kwkbtr merged commit 6ba222c into main May 15, 2023
@kwkbtr kwkbtr deleted the qiskit-conn branch May 15, 2023 10:13
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants