Skip to content
This repository has been archived by the owner on May 10, 2018. It is now read-only.

WebGL support #7

Closed
abveritas opened this issue Oct 13, 2011 · 10 comments
Closed

WebGL support #7

abveritas opened this issue Oct 13, 2011 · 10 comments
Assignees
Milestone

Comments

@abveritas
Copy link

Thanks for this great browser, a really wonderful start. It is added to the repo's of the Chakra-project, and might become the default browser for this linux distribution.
One thing I did change though, is enable webgl for this build. Changed the code for this file:
https://github.com/nowrep/QupZilla/blob/master/src/app/qupzilla.cpp line 269
and added:
http://paste.kde.org/133219/
webgl works perfect with this (Chakra uses qt + a seperate build qtwebkit 2.2)

Hope fully this can be added to standard qupzilla.

@ghost ghost assigned nowrep Oct 13, 2011
@nowrep
Copy link
Member

nowrep commented Oct 13, 2011

Hello,
thank you for your support.
As WebGL enabled QtWebKit is not available in all distributions, I have added optional build define USE_WEBGL to build QupZilla with WebGL enabled.

@nowrep nowrep closed this as completed in 1859bc0 Oct 13, 2011
@abveritas
Copy link
Author

So far this change does not work, settings used:
build() {
cd $srcdir/nowrep-QupZilla-1859bc0/src/
qmake QupZilla.pro
USE_WEBGL=true
make
}

And used many variations for the USE_WEBGL= line
The build goes fine, qupzilla runs, but no webgl available

@nowrep
Copy link
Member

nowrep commented Oct 13, 2011

Uncomment line 21 in QupZilla.pro
You have to actually recompile only mainapplication.cpp file.

@abveritas
Copy link
Author

Uncommenting works, but no switch possible to automate this in the build?

@nowrep
Copy link
Member

nowrep commented Oct 13, 2011

Well, I think I can do it the way you tried at first.
Reading environments variables and if any is present, automatically add define to project.

@abveritas
Copy link
Author

Thanks for trying this. To have it in the repo's, and in a way all packagers can maintain/build this package, we try to have all variables defined in the PKGBUILD.

nowrep added a commit that referenced this issue Oct 13, 2011
@nowrep
Copy link
Member

nowrep commented Oct 13, 2011

Ok,
you can now use
export USE_WEBGL="true"

@abveritas
Copy link
Author

I've tried every variation I could think of for this line, none I tried atually enabled webgl.
Only defines it shows (always):
==> Validating source files with md5sums...
master ... Passed
==> Extracting Sources...
-> Extracting master with bsdtar
==> Starting build()...
Project MESSAGE: Using following defines
Project MESSAGE: QT_NO_DEBUG_OUTPUT
/usr/bin/uic preferences/autofillmanager.ui -o ../build/ui_autofillmanager.h
/usr/bin/uic bookmarks/bookmarksmanager.ui -o ../build/ui_bookmarksmanager.h

@nowrep
Copy link
Member

nowrep commented Oct 14, 2011

Hi,
i tested it by myself and it works fine.

Please run
$ export USE_WEBGL="true"
$ qmake QupZilla.pro

and now it must show USE_WEBGL in defines

My system:
"
david@debian:/Programming/Qt-C++/QupZilla/src$ export USE_WEBGL="true"
david@debian:
/Programming/Qt-C++/QupZilla/src$ qmake
Project MESSAGE: Using following defines
Project MESSAGE: QT_NO_DEBUG_OUTPUT USE_WEBGL
david@debian:/Programming/Qt-C++/QupZilla/src$ unset USE_WEBGL
david@debian:
/Programming/Qt-C++/QupZilla/src$ qmake
Project MESSAGE: Using following defines
Project MESSAGE: QT_NO_DEBUG_OUTPUT
"

It must work for you too.

@nowrep nowrep reopened this Oct 14, 2011
@abveritas
Copy link
Author

Yep, that did it, works great now, issue resolved.

@nowrep nowrep closed this as completed Oct 14, 2011
nowrep added a commit that referenced this issue Jan 22, 2012
nowrep added a commit that referenced this issue Jan 22, 2012
@ghost ghost mentioned this issue Oct 21, 2014
@ghost ghost mentioned this issue Jun 16, 2016
@ghost ghost mentioned this issue Aug 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants