-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the job model still suits our needs #191
Comments
Proposed additional field: cached status/progress (and accompanying last updated field). Maybe a postgres JSON field where we can store cached counts of each status (success, failed, running, queued). Will make showing a list of custom jobs and their progressed (say on the custom jobs list page) much more efficient. |
Also check that API for create and status update matches spec in #193 |
current db structure:
|
@atruskie Does the saved_search specify whether new audio recordings that match the filter are included in the job? As we discussed, including something like What if a user wants to use an existing saved_search, but change only the What is there are lots of similar queries with only this value modified? Not specifying the created_at value may mean that the saved_search will in the future match audio_recordings in other projects not accounted for in the |
Like you said in comment, yeah, the matching new recordings trick will simply be a filter. Nothing explicit. Only requires saved search to filter created date to be less than RE: what if a user want to change that date? simple, we let them edit the date. Simpler yet, we don't even expose any of this functionality in the client until its needed. Good to know we have the architecture to support it though.
This should not be an issue. The query is executed once when the job starts (NB: perhaps worth saving the results, say in csv in job folder on disk, if only for debugging). It is correct when run, not important otherwise. If a user wants more recordings included, a new job to gets executed, which will execute once when started, and be correct when started. |
Decided to change name to |
👍 |
Since we previously designed the job model, the requirements have changed.
Note: no need for JobItems equivalent model/relation
The text was updated successfully, but these errors were encountered: