Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overall_size_bytes field to job model #256

Closed
atruskie opened this issue Feb 24, 2016 · 5 comments
Closed

Add overall_size_bytes field to job model #256

atruskie opened this issue Feb 24, 2016 · 5 comments

Comments

@atruskie
Copy link
Member

The AnalysisJobs model currently tracks aggregate statistics for the saved search it executes like overall_count and overall_duration_seconds.

Feature: add a new field that aggregates the data_length_bytes field from the saved search.

Name options:

  • overall_size_bytes
  • overall_data_length_bytes

Related to #191

@cofiem
Copy link
Contributor

cofiem commented Feb 24, 2016

Justification? Is this only for displaying stats, or will the information be used for some kind of action?

@atruskie
Copy link
Member Author

Mainly for stats. Realizing this prototype interface: https://gyazo.com/c9784b0aeb7983ee6e64e156ed34ad04

Additionally, we'd like to report count/duration/size analyzed stats at a larger scale. It'd be good to track this information now before the system is used in earnest.

@cofiem
Copy link
Contributor

cofiem commented Feb 24, 2016

Sounds good.

Maybe make a separate issue for tracking overall stats? Would this be part of the generic stats table idea?

@atruskie
Copy link
Member Author

Where practical we hope to encode stats in schema explicitly. This minor suggestion is not part of generalized stats idea (for which issue is coming - nailing down a few things offline first).

@cofiem cofiem closed this as completed in 0b9c26d Feb 26, 2016
@atruskie
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants