Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for persistent attribute case conversion #2180

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

hudson-newey
Copy link
Member

@hudson-newey hudson-newey commented Nov 28, 2024

Add tests for persistent attribute case conversion

Changes

  • Adds tests for hotfix 2b61e14. Ensuring that abstract model values are case-converted correctly
  • Re-enables some previously disabled harvest/details.component tests
  • Corrects typing for AbstractModelWithoutId constructor making the raw object passed in the constructor a ReadOnly argument (does not effect typing of object going in, just the usage within the constructor)

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Ensure project linter is not producing any warnings (npm run lint)
  • Ensure build is passing on all browsers (npm run test:all)
  • Ensure CI build is passing
  • Ensure docker container is passing (docs)

This adds tests for the previously deployed hotfix in commit 2b61e14
@hudson-newey hudson-newey added the enhancement New feature or request label Nov 28, 2024
@hudson-newey hudson-newey self-assigned this Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

Size Change: 0 B

Total Size: 3.59 MB

ℹ️ View Unchanged
Filename Size
dist/workbench-client/browser/@ecoacoustics/web-components/abstractComponent-gI12hGSz.js 6.49 kB
dist/workbench-client/browser/@ecoacoustics/web-components/assets/buffer-builder-processor-BhnxGUx8.js 1.16 kB
dist/workbench-client/browser/@ecoacoustics/web-components/assets/high-accuracy-time-processor-BevUJNwo.js 354 B
dist/workbench-client/browser/@ecoacoustics/web-components/attributes-DayhhJl-.js 313 B
dist/workbench-client/browser/@ecoacoustics/web-components/class-map-BJ2wQJjp.js 675 B
dist/workbench-client/browser/@ecoacoustics/web-components/classification-CIken_-O.js 128 B
dist/workbench-client/browser/@ecoacoustics/web-components/components.js 116 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/axes.js 3.19 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/classification.js 1.77 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/data-source.js 63.3 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/decision.js 246 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/help-dialog.js 2.61 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/helpers/constants/contextTokens.js 209 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/indicator.js 1.12 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/info-card.js 1.59 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/logger.js 418 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/media-controls.js 38.2 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/progress-bar.js 1.13 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/spectrogram.js 226 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid-settings.js 1.48 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid-tile.js 408 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid.js 396 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification.js 1.29 kB
dist/workbench-client/browser/@ecoacoustics/web-components/consume-D2RSb1qY.js 614 B
dist/workbench-client/browser/@ecoacoustics/web-components/context-request-event-Bc4uem__.js 239 B
dist/workbench-client/browser/@ecoacoustics/web-components/custom-elements.json 9.74 kB
dist/workbench-client/browser/@ecoacoustics/web-components/decision-BcFlFKnV.js 1.49 kB
dist/workbench-client/browser/@ecoacoustics/web-components/decision-BvBt2W07.js 4.03 kB
dist/workbench-client/browser/@ecoacoustics/web-components/decorators-zsXcIcN9.js 516 B
dist/workbench-client/browser/@ecoacoustics/web-components/directive-B76A7YXI.js 343 B
dist/workbench-client/browser/@ecoacoustics/web-components/if-defined-YSzpD1Zv.js 178 B
dist/workbench-client/browser/@ecoacoustics/web-components/keyboard-c8_TPhbG.js 117 B
dist/workbench-client/browser/@ecoacoustics/web-components/lit-element-CNpxFSzF.js 6.77 kB
dist/workbench-client/browser/@ecoacoustics/web-components/map-D8heArFD.js 184 B
dist/workbench-client/browser/@ecoacoustics/web-components/property-cctOu2Be.js 639 B
dist/workbench-client/browser/@ecoacoustics/web-components/provide-Ce8Vz0mw.js 1.18 kB
dist/workbench-client/browser/@ecoacoustics/web-components/query-sbFTBDPt.js 340 B
dist/workbench-client/browser/@ecoacoustics/web-components/signal-watcher-CbQ3umdl.js 377 B
dist/workbench-client/browser/@ecoacoustics/web-components/signals-core.module-BUxpRF5s.js 1.59 kB
dist/workbench-client/browser/@ecoacoustics/web-components/spectrogram-CYEtaRIV.js 168 kB
dist/workbench-client/browser/@ecoacoustics/web-components/state-DJrhCpxL.js 203 B
dist/workbench-client/browser/@ecoacoustics/web-components/verification-grid-CT6ze_9z.js 12.4 kB
dist/workbench-client/browser/@ecoacoustics/web-components/verification-grid-tile-CvcYjTk-.js 4.49 kB
dist/workbench-client/browser/@ecoacoustics/web-components/watch-D97VecW3.js 1.42 kB
dist/workbench-client/browser/@ecoacoustics/web-components/when-CDK1Tt5Y.js 168 B
dist/workbench-client/browser/assets/environment.json 555 B
dist/workbench-client/browser/assets/test-assets/index.html 21 B
dist/workbench-client/browser/index.html 4.79 kB
dist/workbench-client/browser/main-ZZMQ5PMW.js 1.13 MB
dist/workbench-client/browser/manifest.json 147 B
dist/workbench-client/browser/polyfills-C5CKP5CH.js 12.4 kB
dist/workbench-client/browser/styles-ETV6J7SM.css 39.6 kB
dist/workbench-client/server/952.js 4.21 kB
dist/workbench-client/server/main.js 1.94 MB

compressed-size-action

@hudson-newey hudson-newey marked this pull request as ready for review November 28, 2024 04:45
Copy link
Contributor

Unit Test Results

         6 files           6 suites   8m 31s ⏱️
24 180 tests 23 412 ✔️ 768 💤 0
24 402 runs  23 634 ✔️ 768 💤 0

Results for commit ab0f5ea.

@hudson-newey hudson-newey merged commit c44666c into master Nov 28, 2024
14 checks passed
@hudson-newey hudson-newey deleted the persistent-attribute-tests branch November 28, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants