Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2052 add transport icons in map labels #1073

Merged
merged 8 commits into from
May 10, 2021

Conversation

xem
Copy link
Contributor

@xem xem commented Apr 27, 2021

Description

  • Add public transport icons into map labels
  • 3 icons max, excluding "WALK". 4th and more are omitted
  • icons can be repeated (ex: bus > bus > bus)
  • small, dark ">" icons between each
  • maybe put the duration on the line below on mobile
  • if more than 4 vehicles: put "..." in the middle (deprecated)
  • UPDATE: replace "..." with a little square containing "+2", "+3", etc.
  • We may need to adjust bbox padding on desktop

Screenshots

image
image
image

@xem xem marked this pull request as draft April 27, 2021 14:42
@xem xem requested a review from bbecquet April 28, 2021 15:41
@bbecquet bbecquet force-pushed the QMAPS-2052-public-transport-label-icons branch from 325feca to 8123f2e Compare April 29, 2021 16:48
@bbecquet bbecquet force-pushed the QMAPS-2052-public-transport-label-icons branch from 8123f2e to 4593f63 Compare April 29, 2021 16:53
@bbecquet
Copy link
Contributor

@xem I've pushed a commit with the label rendering in its own component, which was the intent of my first comment and is more maintainable. Let me know what you think of it, I'm interested in your feedback.
I haven't changed the visual result as it already looked nice :)

@xem xem requested a review from bbecquet May 3, 2021 15:57
@bbecquet bbecquet marked this pull request as ready for review May 6, 2021 09:24
@xem xem merged commit f8d235c into master May 10, 2021
@bbecquet bbecquet deleted the QMAPS-2052-public-transport-label-icons branch May 10, 2021 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants