This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Convert PanelManager to a functional component #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
force-pushed
the
react-func-panelmanager
branch
from
7703403
to
0ab529c
Compare
bbecquet
force-pushed
the
react-func-panelmanager
branch
from
0ab529c
to
e0d1306
Compare
amatissart
reviewed
May 24, 2021
src/panel/PanelManager.jsx
Outdated
Comment on lines
22
to
24
| if (poiFilters.category) { | ||
| return CategoryService.getCategoryByName(poiFilters.category)?.getInputValue(); | ||
| } |
There was a problem hiding this comment.
What if the category is not found ?
For consistency, I think that an empty string should be used as a default here too, similarly to the next line.
(eg: http://localhost:3000/places/?type=invalidType could trigger a query to "undefined" after the input is focused)
There was a problem hiding this comment.
Sure. I've made the change, thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the React implementation of the top bar and while it's still fresh, I converted the PanelManager to a functional component.
Why
useDeviceanduseConfig