Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Qmaps 1734 suggest errors #1092

Merged
merged 9 commits into from
May 27, 2021
Merged

Qmaps 1734 suggest errors #1092

merged 9 commits into from
May 27, 2021

Conversation

xem
Copy link
Contributor

@xem xem commented May 24, 2021

Description

Use new, centered error message

  • in suggest
  • when pressing enter after a search with no result
  • when coming from an url with no result

Not done in this ticket:

  • itinerary errors (route not found / public transport)
  • links to a page explaining how to add places on the map
  • handle clicks on error suggest items to take the link into account

Why

Design

Screenshots

image

@xem xem force-pushed the QMAPS-1734-suggest-errors branch from f80ff53 to ed312f5 Compare May 24, 2021 14:42
@xem xem marked this pull request as ready for review May 25, 2021 12:28
@xem xem requested a review from bbecquet May 25, 2021 12:29
src/panel/NoResultMessage.jsx Outdated Show resolved Hide resolved
src/panel/NoResultMessage.jsx Outdated Show resolved Hide resolved
src/panel/NoResultPanel.jsx Show resolved Hide resolved
@xem xem requested a review from amatissart May 26, 2021 08:59
Copy link
Contributor

@amatissart amatissart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor styling comments

src/panel/NoResultMessage.jsx Outdated Show resolved Hide resolved
src/panel/NoResultPanel.jsx Show resolved Hide resolved
@xem xem requested a review from amatissart May 26, 2021 13:54
@bbecquet bbecquet merged commit 2c134f2 into master May 27, 2021
@bbecquet bbecquet deleted the QMAPS-1734-suggest-errors branch May 27, 2021 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants