Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Change error message when no matching point in area #1102

Merged
merged 2 commits into from
May 31, 2021

Conversation

bbecquet
Copy link
Contributor

@bbecquet bbecquet commented May 31, 2021

Description

New wording and action for the error message when there is no matching point in the area for a "category" result.

Screenshots

Before After
Screen%20Shot%202021-05-31%20at%2015 25 36 Screen%20Shot%202021-05-31%20at%2015 37 36

@bbecquet bbecquet requested a review from xem May 31, 2021 15:02
Copy link
Contributor

@xem xem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now!
I approve but, any idea why the panel is so tall on mobile?
image

(it's not a regression coming from this branch, but I wonder if it should be fixed... by making the panel as high as its content)

@bbecquet
Copy link
Contributor Author

@xem
Ah, yes we could. In theory it's just a matter of passing the right fitContent property to the Panel component in CategoryPanel, and make sure its reset when there is no more error to ensure the normal behavior is kept.
This dynamic panel sizing is one of the fragile parts of the app, which used to give a lot of bugs, so there may be some traps :) You could make a dedicated PR for that if you want.

@bbecquet bbecquet merged commit f1b1939 into Qwant:master May 31, 2021
@bbecquet bbecquet deleted the QMAPS-2138-no-poi-msg branch May 31, 2021 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants