This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
QMAPS-2352 add 3 logs for surveys #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 3 logs:
Telemetry.SURVEY_DISPLAY
Telemetry.SURVEY_CLOSE
Telemetry.SURVEY_ANSWER
they all send an additional data "id" equal to the current survey's id.
if a survey isn't displayed (ineligible test group, current date not between the survey's start and end, or survey already closed in a previous session), no logs are done.