Redirect to the base url when searching empty query or equivalent #1229

sdrll · 2021-11-03T14:12:41Z

State : Draft (need to discuss)

Description

New behabior from Idunn fulltext endpoint :

Return http response 204 when the query is acceptable, but no results are return from elasticsearch
Return http response 200 when the query is acceptable and results are return from elasticsearch OR the query is empty (or equivalent) and no result are returned from ES

We would like to redirect to the base url in order to avoid : Sorry, we could not find this place when the query is empty or equivalent

The goal of the PR is to have a base to discuss with @xem.

…n (empty query or equivalent)

sdrll added 3 commits November 3, 2021 15:08

Redirect to the base url when we received a 204 http answer from Idun…

0b1afd7

…n (empty query or equivalent)

fix linter

bf95772

WIP : update with the new http fulltext endpoint rule

353e56b

sdrll marked this pull request as draft November 3, 2021 16:42

sdrll marked this pull request as ready for review November 8, 2021 08:33

sdrll marked this pull request as draft November 8, 2021 08:39

Add string in the query field of the mock idunn json reponse

faa1b0e

sdrll marked this pull request as ready for review November 8, 2021 11:07

sdrll requested a review from xem November 8, 2021 13:20

remi-dupre approved these changes Nov 8, 2021

View reviewed changes

xem approved these changes Nov 8, 2021

View reviewed changes

xem merged commit 3d0d615 into master Nov 8, 2021