Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2359: show disabled panel history, save switch setting in localStorage #1230

Merged
merged 1 commit into from
Nov 15, 2021
Merged

QMAPS-2359: show disabled panel history, save switch setting in localStorage #1230

merged 1 commit into from
Nov 15, 2021

Conversation

xem
Copy link
Contributor

@xem xem commented Nov 8, 2021

Description

  • If the searchHistory feature flag is enabled, show a "Search History" in the side menu
  • when clicking the link or visiting /history/ url, show the "disabled" history panel (header + text + switch only)
  • the value of the switch is saved in localStorage.
  • If the switch has been enabled, it will appear enabled after reloading the /history/ page
  • The history in the TopBar and Directions search fields will be enable only if the switch has been enabled
  • TODO: provide an URL for the link in the panel
  • TODO in another PR: show the "enabled empty" panel when the switch is enabled
  • TODO: final design

Screenshots

image
image
image

@sdrll sdrll self-requested a review November 9, 2021 09:27
sdrll
sdrll approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@sdrll sdrll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, (btw, React panel behavior is (very) close to Angular)

src/panel/history/HistoryPanel.jsx Show resolved Hide resolved
@xem xem merged commit 28ede5e into master Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Spasfonx Spasfonx Spasfonx approved these changes

@sdrll sdrll sdrll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xem @Spasfonx @sdrll