This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
app.js: prevent mutation of global config #1233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like the best way to fix this indefinitely would be to clone the global config, but it doesn't seem like this is something idiomatic in Javascript: https://attacomsian.com/blog/javascript-clone-objects (describes a solution based on a library, and the other one consists in serializing then de-serializing JSON ... lol nope).
So I guess we will have to be careful never mutating the global configuration.
EDIT: maybe we'd want to use the no-mutation lint from https://github.com/jhusain/eslint-plugin-immutable ? It seems unacceptable to me that eslint accepts this by default: