Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Qmaps 2373 / 2374 history modals #1234

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Qmaps 2373 / 2374 history modals #1234

merged 2 commits into from
Nov 30, 2021

Conversation

xem
Copy link
Contributor

@xem xem commented Nov 29, 2021

Description

Show confirmation modals before clearing or disabling local search history.
Both use the same component
Disabling the history also provokes clearing the history
Desktop / Mobile designs are different (buttons stacked on mobile)
Also in this MR: updated the caniuse dependency

Screenshots

Modal 1 (seen on desktop):
image

Modal 2 (seen on mobile):
image

@xem xem requested a review from sdrll November 29, 2021 15:58
Copy link
Contributor

@sdrll sdrll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xem xem merged commit 619d8e9 into master Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants