Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Qmaps 2158 help center links #1236

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Qmaps 2158 help center links #1236

merged 6 commits into from
Dec 1, 2021

Conversation

xem
Copy link
Contributor

@xem xem commented Nov 30, 2021

Description

  • Provide up-to-date links for the no geolocation & no result found help pages in 4 languages
  • Display buttons in geolocation modals and no-result suggest that redirect to these help pages in a new tab

Screenshots

image
image

@xem xem marked this pull request as draft November 30, 2021 15:47
@xem xem marked this pull request as ready for review November 30, 2021 16:39
@xem xem requested a review from sdrll November 30, 2021 16:42
src/modals/GeolocationModal.jsx Show resolved Hide resolved
config/constants.yml Show resolved Hide resolved
variant="tertiary"
onMouseDown={() => window.open(helpCenterLink)}
>
<IconExternalLink /> {_('Add a missing place on the map')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the text only be in english ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source strings are in english, and when we surround them with _(...), it allows to translate them on transifex, but that can only be done after the feature is merged on master

@xem xem merged commit cf1fd1e into master Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants