Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2356 show history prompt in suggest if feature flag enabled and prompt not yet answered #1237

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

xem
Copy link
Contributor

@xem xem commented Dec 8, 2021

Description

  • ensure suggest doesn't close when the mouse clicks outside of the window (not asked in the ticket but very convenient for debug and UX)
  • when the search field is focused and empty, show history prompt panel instead of the suggest if the history feature flag is enabled and is this prompt is not yet answered
  • TODO (in next MRs): make buttons clickable, provide link URL, final design

Why

Why this PR is needed. Feature, step to something bigger, bug, etc.

Screenshots

image

@xem xem requested review from sdrll and remi-dupre December 8, 2021 16:14
sdrll
sdrll previously approved these changes Dec 9, 2021
src/panel/app_panel.js Outdated Show resolved Hide resolved
@xem xem merged commit 3867bc1 into master Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants