Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2357, QMAPS-2358, QMAPS-2295 history in suggest #1240

Merged
merged 7 commits into from
Dec 29, 2021

Conversation

xem
Copy link
Contributor

@xem xem commented Dec 13, 2021

Description

if the history feature flag is enabled:

  • show history prompt in suggest, on focus, under the topBar field, if it hasn't been answered yet and if the field is empty (hide the favorites in that case)
  • keep it visible until yes or no has been clicked, because otherwise everything disappears before the click is registered properly.
  • show the accept / refuse messages and enable / don't enable the history after clicking the yes / no buttons
  • don't show the message again after filling and emptying the field or after navigating the app and focusing the field again
  • show a message in the suggest footer if the field is focused and empty and if history items are present.
  • include mobile/pc info in telemetry
  • TODO: design
  • TODO: final links (for history page and help center)

Screenshots

image
image
image
image

@xem xem marked this pull request as draft December 13, 2021 16:31
@xem xem changed the title QMAPS-2358 history-suggest wip QMAPS-2357, QMAPS-2358 history in suggest Dec 22, 2021
@xem xem marked this pull request as ready for review December 22, 2021 16:09
@xem xem requested review from sdrll and remi-dupre December 22, 2021 16:09
@xem xem changed the title QMAPS-2357, QMAPS-2358 history in suggest QMAPS-2357, QMAPS-2358, QMAPS-2295 history in suggest Dec 29, 2021
src/components/ui/Suggest.jsx Show resolved Hide resolved
@xem xem merged commit 380646e into master Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants