This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
QMAPS-2404 design WIP #1241
Merged
QMAPS-2404 design WIP #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdrll
reviewed
Jan 11, 2022
There was a problem hiding this comment.
Thank you for the PR. In addition to the comment, I have one major and one minor remark :
- Major : On testing, After enabling history for the first time, the Suggest is not displaying the history. I have to refresh to make it works. (I can show to reproduce)
- Minor : I have upgraded to npm8.3 and the prompt ask me to update a package on build :
Browserslist: caniuse-lite is outdated. Please run: npx browserslist@latest --update-dbmaybe you have the same issue without upgrading npm ?
|
Hi @fatal69100 , thanks!
|
sdrll
previously approved these changes
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final design for history in suggest
Screenshots
Mobile
Desktop