Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2440 fix history #1246

Merged
merged 7 commits into from
Jan 25, 2022
Merged

QMAPS-2440 fix history #1246

merged 7 commits into from
Jan 25, 2022

Conversation

xem
Copy link
Contributor

@xem xem commented Jan 24, 2022

Description

  • Corriger les liens "manage" dans le suggest (sur l'instance de dev il manque "/maps" dans l'url)
  • Dans le suggest, après avoir cliqué sur oui ou non, bien aligner l'icone menu au texte et enlever le "." avant l'icone
  • Quand le panel my history est vide et désactivé, lui mettre une height auto.
  • Quand il est vide et activé: height auto +margin "32px auto" sur le message au centre (your history will appear here)
  • Quand il est activé et rempli: full height, et coller la scrollbar à droite lorsqu'il y a besoin de scroller.
  • Coller le switch du panel my history a droite sur mobile si l'écran mesure plus de 450px de large
  • Utiliser la bonne icone dans la modale "désactiver l'historique" (celle en pointillés)
  • Panel my history plié sur mobile: trop de marge en haut, "show history" est caché. Faire comme Favoris.
  • Tooltips: "Effacer" sur la poubelle + l'icône passe en noir au hover (https://zpl.io/aM3r5RJ), "Activer" ou "Désactiver" sur le switch
  • Width auto + centrage sur les boutons des modales history (qui apparaissent quand on désactive / efface l'historique)
  • Modales: centrer le texte et décoller la croix en haut à droite

Testing

@remi-dupre @fatal69100 quand vous testerez ce ticket, voici des commandes utiles à entrer dans votre console JS:

  • Vider l'historique (afin de revoir le prompt lors du focus du champ de recherche par exemple)
    localStorage.clear()

  • Remplir l'historique avec des items de différentes dates (après avoir activé l'historique)

localStorage.qmaps_v1_search_history_v1 = `[{"type":"poi","date":1643021091713,"item":{"id":"admin:osm:relation:170100","name":"Nice (06000-06300)","type":"zone","latLon":{"lat":43.7009358,"lng":7.2683912},"className":"","subClassName":"","bbox":[7.1819535,43.6454189,7.323912,43.7607635],"value":"Nice (06000-06300), Alpes-Maritimes, France","queryContext":{"term":"Nice","ranking":1,"lang":"fr","position":{"lat":"43.700","lon":"7.300","zoom":"11.000"}},"address":{"stateDistrict":"Alpes-Maritimes","country":"France"}}},{"type":"poi","date":1632581629687,"item":{"id":"admin:osm:relation:6581513","name":"Hôtel de Ville (13002)","type":"zone","latLon":{"lat":43.2972752,"lng":5.3672223},"className":"","subClassName":"","bbox":[5.3604597,43.2941413,5.3743739999999995,43.2994358],"value":"Hôtel de Ville (13002), 2e Arrondissement, Marseille, Bouches-du-Rhône, Provence-Alpes-Côte d'Azur, France","queryContext":{"term":"hotel","ranking":1,"lang":"fr","position":{"lat":"43.700","lon":"7.300","zoom":"17.000"}},"address":{"cityDistrict":"2e Arrondissement","city":"Marseille","stateDistrict":"Bouches-du-Rhône","state":"Provence-Alpes-Côte d'Azur","country":"France"}}},{"type":"poi","date":1641581639418,"item":{"id":"osm:way:5013364","name":"Tour Eiffel","type":"poi","latLon":{"lat":48.858260156496016,"lng":2.2944990157640612},"className":"attraction","subClassName":"attraction","value":"Tour Eiffel (Paris)","queryContext":{"term":"tour eiffel","ranking":1,"lang":"fr","position":{"lat":"43.300","lon":"5.400","zoom":"15.000"}},"address":{"street":"5 Avenue Anatole France","suburb":"Quartier du Gros-Caillou","cityDistrict":"Paris 7e Arrondissement","city":"Paris","stateDistrict":"Paris","state":"Île-de-France","country":"France","label":"5 Avenue Anatole France (Paris)"}}}]`

@xem xem marked this pull request as draft January 24, 2022 10:26
@xem xem marked this pull request as ready for review January 24, 2022 16:35
@xem xem requested review from sdrll and remi-dupre January 24, 2022 16:36
Copy link
Contributor

@remi-dupre remi-dupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to have an exhaustive tour on mobile / desktop, LGTM 👍

@xem xem changed the title QMAPS-2440 fix links QMAPS-2440 fix history Jan 25, 2022
@xem xem merged commit d9f630b into master Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants