Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2329 feat: reservation module #1249

Merged
merged 10 commits into from
Feb 8, 2022
Merged

QMAPS-2329 feat: reservation module #1249

merged 10 commits into from
Feb 8, 2022

Conversation

Grafikart
Copy link
Contributor

Description

Add a reservation module for tripadvisor hotel

Why

Why not ;)

Screenshots

image

@xem
Copy link
Contributor

xem commented Jan 31, 2022

Hi @Grafikart , thanks for the PR. Much progress!

Here are the last details that need to be fixed, as discussed on Mattermost:

  • add spellcheck="false" on the fields to avoid these wavy lines on focus on Chrome
    image

  • this problem is also present in the IA on Chrome when the field is focused

  • the date picker is not fully visible on 13" desktops. As seen with Design, it can be moved up while they're thinking of a smaller version.
    image

  • Use the following labels: "18 years old and more", "Between 0 and 17 years old", "Age of child N"

Besides that it looks great, thanks.

@xem
Copy link
Contributor

xem commented Feb 7, 2022

Thanks!
There's two final edits I'd like to add:

  • Make the date picker flelds "spellcheck=false"
  • Add a button to easily validate the date picker choice and see the form again (the form is hidden when we are on a small screen)

@xem xem merged commit 57e7929 into Qwant:master Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants