This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Qmaps 2394 dedup intentions #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-dupre
reviewed
Feb 9, 2022
There was a problem hiding this comment.
Currently the deleteQuery function assumes there is at most one duplicate. While this is true in a normal use it may be more robust to remove all stored elements that match the new one? (For example, even though this was not in production yet, changes similar to this one that change the equality criteria may lead to having several duplicates of a same item in the history)
remi-dupre
approved these changes
Feb 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Searches containing:
Must be present only once in the history panel, even if the search is performed many times
NB: This PR also fixes a React key duplication error in the History Panel.
NB2: until now, the dedup test was looking for the "fullTextQuery" item, but this item has been removed, and afaik, it was not necessary to check the equality between two queries.