Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2428 - Tripadvisor / Pagesjaunes in history #1280

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

pascaloliv
Copy link
Member

Description

Add TripAdvisor and PagesJaunes POI to the history.
Add POI category to the history too.

@pascaloliv pascaloliv marked this pull request as draft February 18, 2022 16:40
@pascaloliv pascaloliv force-pushed the QMAPS-2428-tripadvisor-pagesjaunes-in-history branch from dfb313c to f653ad3 Compare February 21, 2022 10:21
@pascaloliv pascaloliv changed the title Draft: QMAPS-2428 - Tripadvisor / Pagesjaunes in history QMAPS-2428 - Tripadvisor / Pagesjaunes in history Feb 21, 2022
@pascaloliv pascaloliv requested a review from xem February 21, 2022 14:29
@pascaloliv pascaloliv marked this pull request as ready for review February 21, 2022 14:29
@xem
Copy link
Contributor

xem commented Feb 21, 2022

To be discussed with Charlotte.

During my tests on this branch, I remarked that the following elements were added in the history:

  • intention (ex: parc / parc nice / hotel / hotel nice / restaurant / restaurant nice)
  • TripAd POI (ex: one hotel from a poi list)
  • PJ POI (ex: a restaurant from a poi list)
  • OSM PoI (ex: type"tour eiffel" or "societe generale nice musiciens" or "hotel negresco nice" in the search field)

And these elements were not:

  • LatLon POI (gps coordinates if clicking anywhere on the map)
  • OSM poi (if it is clicked on the map)

Other point to discuss wwith Charlotte:
Should we show intentions from the history in the suggest? I think we should not. See example below:

image

xem
xem previously approved these changes Feb 22, 2022
Copy link
Contributor

@xem xem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for now, but to discuss before release

@xem
Copy link
Contributor

xem commented Feb 23, 2022

image
i think the "nearby" should not appear in the suggest under a category name

@pascaloliv pascaloliv merged commit 495587f into master Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants