Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2479 fix age list #1282

Merged
merged 4 commits into from
Feb 23, 2022
Merged

QMAPS-2479 fix age list #1282

merged 4 commits into from
Feb 23, 2022

Conversation

xem
Copy link
Contributor

@xem xem commented Feb 22, 2022 •
edited
Loading

Description

  • I don't reproduce the Firefox issue anymore (white dropdown)
  • This MR includes a fix of the ages list (0-17 instead of 0-16) + no label for the age 0 + correct default param for Field (it caused a React warning)

NB: I'm gonna remove the empty value in the in the design system. The reservation form is the only one that uses it

@xem xem requested a review from pascaloliv February 22, 2022 10:21
pascaloliv
pascaloliv suggested changes Feb 23, 2022
View reviewed changes
Copy link
Member

@pascaloliv pascaloliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add setInitialLoading in useEffect dep array in Reservation/Reservation.jsx to avoid warning.

@xem xem requested a review from pascaloliv February 23, 2022 08:30
@xem xem merged commit bf4d8d3 into master Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pascaloliv pascaloliv pascaloliv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xem @pascaloliv