Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2517 - Fix console warnings for POI Tripadvisor + suggestion list border #1285

Merged
merged 4 commits into from
Feb 28, 2022
Merged

QMAPS-2517 - Fix console warnings for POI Tripadvisor + suggestion list border #1285

merged 4 commits into from
Feb 28, 2022

Conversation

pascaloliv
Copy link
Member

Description

  1. This PR fix warnings on POI TripAdvisor and History panel.
  • remove horizontal prop on <Flex>
  • href replaced from javascript:; to <button> element
  1. Suggestion list improved to fit the original design (border-top).

@pascaloliv pascaloliv force-pushed the QMAPS-2517-fix-warnings-poi-tripadvisor branch from 2104508 to 3e6ec82 Compare February 24, 2022 10:25
@pascaloliv pascaloliv requested a review from xem February 28, 2022 10:01
xem
xem suggested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@xem xem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but clicking on the "manage" button in the suggest sometimes (randomly?) has no effect. See video :

Qwant.Maps.-.Google.Chrome.2022-02-28.16-11-33.mp4

@pascaloliv pascaloliv force-pushed the QMAPS-2517-fix-warnings-poi-tripadvisor branch from 3e6ec82 to b9c23a0 Compare February 28, 2022 15:18
@xem xem self-requested a review February 28, 2022 15:33
@pascaloliv pascaloliv merged commit ad58f9c into master Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xem xem xem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascaloliv @xem