Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2520 - Viewport body height miscalculation with 100vh #1287

Merged
merged 1 commit into from
Feb 28, 2022
Merged

QMAPS-2520 - Viewport body height miscalculation with 100vh #1287

merged 1 commit into from
Feb 28, 2022

Conversation

pascaloliv
Copy link
Member

Description

Buggy behaviour when using Qmaps on Safari - focusing the top bar and focusing out

Screenshots

Issue:
https://user-images.githubusercontent.com/442681/155574553-aefa5809-4152-4ec5-a398-caf9830128bc.mov

@pascaloliv pascaloliv requested a review from xem February 28, 2022 10:01
xem
xem approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@xem xem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I wonder if this fix should also be present in qwant-ponents (and Phoenix) ?

@pascaloliv
Copy link
Member Author

nice, I wonder if this fix should also be present in qwant-ponents (and Phoenix) ?

This body rule should live in Qwantcom & Maps repositories - but not in qwant-ponents in my opinion - which should be project agnostic.

@pascaloliv pascaloliv merged commit ac7b082 into master Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xem xem xem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascaloliv @xem