QMAPS-2532 don't mix favorites with hisory in suggest

src/adapters/suggest_sources.js

@@ -28,18 +28,18 @@ export function suggestResults(
   // - get all the history items
   // - ignore the items that are already present in the favourites list
   // - keep the N first items (where N = maxHistoryItems)
-  const historyItems =
-    maxHistoryItems > 0
-      ? getHistoryItems(term, { withIntentions: withCategories })
-          .slice(0, maxHistoryItems)
-          .map(item => {
-            item._suggestSource = 'history';
-            if (favoriteItems.find(favorite => favorite.id === item.id)) {
-              item._isFavorite = true;
-            }
-            return item;
-          })
-      : [];
+  let historyItems =
+    maxHistoryItems > 0 ? getHistoryItems(term, { withIntentions: withCategories }) : [];
+
+  if (term !== '') {
+    historyItems = historyItems.filter(
+      item => !favoriteItems.find(favorite => favorite.id === item.id)
+    );
+  }
+  historyItems = historyItems.slice(0, maxHistoryItems).map(item => {
+    item._suggestSource = 'history';
+    return item;
+  });
 
   // Field focused and empty: get history + favourite items, but no favourites if history items are present
   if (term === '') {

src/components/ui/SuggestItem.jsx

@@ -34,7 +34,7 @@ const SuggestItem = ({ item }) => {
   const props = {};
   const variants = [];
   const isHistory = item._suggestSource === 'history';
-  const isFavorite = item instanceof PoiStore || item._isFavorite === true;
+  const isFavorite = item instanceof PoiStore === true;
   if (isFavorite) {
     variants.push('favorite');
   } else if (isHistory) {