Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

QMAPS-2623 - Add zustand + refactor Menu and Products drawers logic #1318

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

pascaloliv
Copy link
Member

@pascaloliv pascaloliv commented Mar 25, 2022

Description

  • Implement zustand, zustand-persist, zustand dev tools (to log in Redux dev tools)
  • Add /store folder to create zustand store and split logic in slices (different files for ui, result, history, favs, etc..) to be scalable in the future.
  • Refactor Menu and top bar a bit to use zustand based open/close state.
  • Add qwant-ponents d.ts types on-the-fly (not the best solution but qwant-ponents don't have their own TS types yet)

@sdrll
Copy link
Contributor

sdrll commented Mar 28, 2022

I am not sure, I can review correctly the pr due to lack of knowledge :s it would be better to wait xem's review ?

xem
xem previously approved these changes Mar 30, 2022
@xem
Copy link
Contributor

xem commented Mar 30, 2022

Hi,
I tested locally and it's fine!
(though, npm run start shows a new warning, but I don't think it's related to this PR)
image

The code is OK too except useStore(store=>store) that can be simplified in useStore()

@pascaloliv pascaloliv merged commit b5fae65 into master Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants