This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Add Storybook #1326
Merged
Add Storybook #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascaloliv
force-pushed
the
add-storybook
branch
from
98ef0e2
to
cc848c8
Compare
sdrll
approved these changes
Apr 7, 2022
| @@ -9,7 +9,7 @@ module.exports = function (api) { | |||
| browsers: ['Chrome >= 60', 'Firefox >= 44', 'Safari >= 10', 'Edge >= 17'], | |||
| }, | |||
| useBuiltIns: 'entry', | |||
| corejs: 2, | |||
| corejs: 3, | |||
There was a problem hiding this comment.
Was it an automatic change from babel migration ?
There was a problem hiding this comment.
Nothing automatic.
@babel/polyfill was using inside corejs (in version 2).
This upgrade was necessary because Babel recommend not using @babel/polyfil anymore.
So I update core-js version to 3 in this MR.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Storybook to manage UI components documentation / sandboxing etc. More info on StorybookJS.
Remove deprecated @babel/polyfill and add
core-js/stable+regenerator-runtime/runtime(Babeljs Reference)Add PlaceIcon story for example purpose