-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
Julien-laville
commented
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbgriesner not related to this feature but still fixed |
7783e5e
to
1b4256d
Compare
src/ui_components/search_input.js
Outdated
@@ -40,6 +41,9 @@ export default class SearchInput { | |||
this.searchInputHandle = document.querySelector(tagSelector) | |||
this.handleKeyboard() | |||
this.suggest = new Suggest(tagSelector, (selectedPoi) => this.selectItem(selectedPoi)) | |||
PoiStore.getAll().then((storeItems) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initializing suggested favorites in the constructor of the search input component means the suggestions won't be updated when a new favorite is added.
Steps to reproduce the bug:
- focus on search focus to see the list of current favorites as suggestion
- add a new favorite
- focus again on the search input, the new favorite is not displayed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will fix that in the future ticket favorite synch, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, there is also an issue when clearing the field of direction input, we don't have the suggestion anymore, but I guess it is not directly related to this PR and will be fixed in a future ticket.
1b4256d
to
9823e54
Compare