This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Prerender favorite in autocompletes #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien-laville
commented
Mar 18, 2019
Julien-laville
commented
jbgriesner
previously requested changes
Mar 19, 2019
There was a problem hiding this comment.
Steps to reproduce the bug corresponding to the image below:
- click "directions"
- select whatever start and end
- remove the end point (by clicking the small cross on the right of the field)
- click in the text field of the end point: tadaa you should see twice "your position"
|
@jbgriesner not related to this feature but still fixed |
Julien-laville
force-pushed
the
QMAPS-722_prefill_favorite_autocomplete
branch
from
7783e5e
to
1b4256d
Compare
sujeebant
reviewed
Mar 26, 2019
src/ui_components/search_input.js
Outdated
| @@ -40,6 +41,9 @@ export default class SearchInput { | |||
| this.searchInputHandle = document.querySelector(tagSelector) | |||
| this.handleKeyboard() | |||
| this.suggest = new Suggest(tagSelector, (selectedPoi) => this.selectItem(selectedPoi)) | |||
| PoiStore.getAll().then((storeItems) => { | |||
There was a problem hiding this comment.
Initializing suggested favorites in the constructor of the search input component means the suggestions won't be updated when a new favorite is added.
Steps to reproduce the bug:
- focus on search focus to see the list of current favorites as suggestion
- add a new favorite
- focus again on the search input, the new favorite is not displayed
There was a problem hiding this comment.
We will fix that in the future ticket favorite synch, thanks
There was a problem hiding this comment.
Okay, there is also an issue when clearing the field of direction input, we don't have the suggestion anymore, but I guess it is not directly related to this PR and will be fixed in a future ticket.
sujeebant
previously approved these changes
Mar 26, 2019
amatissart
force-pushed
the
QMAPS-722_prefill_favorite_autocomplete
branch
from
1b4256d
to
9823e54
Compare
amatissart
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.