This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Fix back button #153
Merged
Fix back button #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
reviewed
Mar 21, 2019
G-Ray
reviewed
Mar 25, 2019
| @@ -22,9 +20,18 @@ export default class DirectionPanel { | |||
| this.origin = null | |||
| this.destination = null | |||
| this.vehicle = this.vehicles.DRIVING | |||
| this.roadMapPanel = new RoadMapPanel() | |||
| this.roadMapPanel = new RoadMapPanel(this) | |||
There was a problem hiding this comment.
Would it be possible to register a callback instead of passing this ? I find a bit dangerous to let roadMapPanel handle the instance
There was a problem hiding this comment.
I mean, a callback to handle a close event for instance
There was a problem hiding this comment.
good question, i find it more elegant than register callback and let the panel handle his own close method.
G-Ray
reviewed
Mar 25, 2019
G-Ray
reviewed
Mar 25, 2019
Julien-laville
force-pushed
the
QMAPS-717_direction_mobile_back_action_fix
branch
from
3695af3
to
e858956
Compare
G-Ray
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.