New design for Masq #164
New design for Masq #164
Conversation
sujeebant
force-pushed
the
favorite-list-masq-footer
branch
2 times, most recently
from
6030463
to
ac9ef5d
Compare
| } | ||
|
|
||
| waitForClose() { | ||
| if (!this.opened) { |
There was a problem hiding this comment.
i don't understand the async of this method
There was a problem hiding this comment.
The masq_favorite_modal is opened when a user that is not connected to masq tries to add a favorite to offer him to connect to masq. In the case he connects to masq through the modal, we have to add the favorite in his masq profile, otherwise we add it to the local storage as usual. That's why we need to wait for the modal to close before doing something in the poi panel, that's how the waitForClose promise is used.
There are alternative such as using events or just calling store.add in the modal component before closing so the poi_panel doesn't have to await the closing of the modal.
| } | ||
|
|
||
| async previousStep () { | ||
| if (this.step === 1) { |
There was a problem hiding this comment.
i think there is a more elagant way to cycle over a limit list of integer
sujeebant
force-pushed
the
favorite-list-masq-footer
branch
2 times, most recently
from
be94533
to
861cf16
Compare
sujeebant
requested review from
Julien-laville and
amatissart
and removed request for
Julien-laville
sujeebant
force-pushed
the
favorite-list-masq-footer
branch
from
861cf16
to
5431711
Compare
sujeebant
force-pushed
the
favorite-list-masq-footer
branch
from
d56c4d0
to
1167554
Compare
Handle login and logout events fired by masq-lib in a tab to inform other tabs that a user logged in or logged out.
config/default_config.yml
Outdated
| @@ -30,7 +30,7 @@ masq: | |||
| enabled: false | |||
| title: Qwant Maps | |||
| desc: Maps application developed by Qwant | |||
| icon: https://www.qwant.com/maps/statics/images/qwant-logo.svg | |||
| icon: https://raw.githubusercontent.com/QwantResearch/erdapfel/masq-new-image/public/images/masq/maps-app.png | |||
There was a problem hiding this comment.
why not including this image on this branch, and use it via a relative url for example ?
src/views/masq_favorite_modal.dot
Outdated
| <br/> | ||
| <div class="modal__masq_favorite__details"> | ||
| <i class="modal__masq_favorite__arrow"></i> | ||
| <a href="https://github.com/QwantResearch/masq-app" rel="noopener" target="_blank">{{= _('More Details') }}</a> |
There was a problem hiding this comment.
should this url be configured ?
amatissart
force-pushed
the
favorite-list-masq-footer
branch
from
6cbb82e
to
9b27ba2
Compare
No description provided.