-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
6030463
to
ac9ef5d
Compare
} | ||
|
||
waitForClose() { | ||
if (!this.opened) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand the async of this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The masq_favorite_modal is opened when a user that is not connected to masq tries to add a favorite to offer him to connect to masq. In the case he connects to masq through the modal, we have to add the favorite in his masq profile, otherwise we add it to the local storage as usual. That's why we need to wait for the modal to close before doing something in the poi panel, that's how the waitForClose promise is used.
There are alternative such as using events or just calling store.add in the modal component before closing so the poi_panel doesn't have to await the closing of the modal.
} | ||
|
||
async previousStep () { | ||
if (this.step === 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there is a more elagant way to cycle over a limit list of integer
be94533
to
861cf16
Compare
861cf16
to
5431711
Compare
d56c4d0
to
1167554
Compare
Handle login and logout events fired by masq-lib in a tab to inform other tabs that a user logged in or logged out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions about icons and images:
- how is used
masq.icon
url ? and what is a better default than a github url ? - "masq-app".png seems to be unused
- could we be optimize the gif files ? (not urgent though)
config/default_config.yml
Outdated
@@ -30,7 +30,7 @@ masq: | |||
enabled: false | |||
title: Qwant Maps | |||
desc: Maps application developed by Qwant | |||
icon: https://www.qwant.com/maps/statics/images/qwant-logo.svg | |||
icon: https://raw.githubusercontent.com/QwantResearch/erdapfel/masq-new-image/public/images/masq/maps-app.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not including this image on this branch, and use it via a relative url for example ?
src/views/masq_favorite_modal.dot
Outdated
<br/> | ||
<div class="modal__masq_favorite__details"> | ||
<i class="modal__masq_favorite__arrow"></i> | ||
<a href="https://github.com/QwantResearch/masq-app" rel="noopener" target="_blank">{{= _('More Details') }}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this url be configured ?
6cbb82e
to
9b27ba2
Compare
No description provided.