This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
QMAPS-759 display POI image on top right if available #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien-laville
suggested changes
Apr 10, 2019
|
Thanks for these reviews @Julien-laville ! |
|
I have a JS failure when clicking on this element:
The JS error is the following: |
|
Is there any POI with an image? Even the Eiffel tower doesn't have one... |
GuillaumeGomez
force-pushed
the
QWANT-759
branch
from
17bdee5
to
e07f1df
Compare
GuillaumeGomez
force-pushed
the
QWANT-759
branch
2 times, most recently
from
516784b
to
3247c4c
Compare
GuillaumeGomez
force-pushed
the
QWANT-759
branch
3 times, most recently
from
9770c4e
to
aa4916c
Compare
GuillaumeGomez
force-pushed
the
QWANT-759
branch
from
aa4916c
to
b7b8663
Compare
GuillaumeGomez
force-pushed
the
QWANT-759
branch
from
149e786
to
cb17084
Compare
amatissart
reviewed
Apr 26, 2019
| @@ -101,6 +99,8 @@ pois: | |||
| panelName: internet_access | |||
| - apiName: contact | |||
| panelName: contact | |||
| - apiName: images | |||
| panelName: images | |||
There was a problem hiding this comment.
shouldn't we remove this unused block for now ?
There was a problem hiding this comment.
It won't be unused for long so I'd be in favor to keep it for now.
src/views/poi_bloc/wiki.dot
Outdated
| {{?}} | ||
|
|
||
| {{? !this.wiki.description && !this.wiki.url }} | ||
| <a class="poi_panel__info__wiki__link" rel="noopener noreferrer" target="_blank" href="https://www.wikidata.org/wiki/{{= this.htmlEncode(this.tag) }}">{{= _('Read more on Wikidata') }}</a> | ||
| <a class="poi_panel__info__wiki__link" rel="noopener noreferrer" target="_blank" href="https://www.wikidata.org/wiki/{{= this.htmlEncode(this.tag) }}"> | ||
| <i class="icon-chevrons-right"></i><span>{{= _('WIKIDATA') }}</span></a> |
There was a problem hiding this comment.
i think this second "wikidata" link is here for historical reasons and is never used. It should be removed.
amatissart
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.