This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Masq: add modal while activating Masq #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
reviewed
May 13, 2019
sujeebant
force-pushed
the
masq-activation-modal
branch
from
fec4149
to
a0a275c
Compare
amatissart
reviewed
May 15, 2019
src/modals/masq_activating_modal.js
Outdated
|
|
||
| this.modal = new Modal(this, MasqActivatingModalView, false) | ||
|
|
||
| this.opened = false |
There was a problem hiding this comment.
this flag is not used. And as this.activating is true by default, the modal and the video are present in DOM at app start. (Chromium at least tries to load the .mp4 before it is visible)
There was a problem hiding this comment.
Fixed !
removed opened flag and made activating false by default
src/views/masq_activating_modal.dot
Outdated
| <div class="modal__masq_activating__body"> | ||
| {{? this.activating}} | ||
| <div class="modal__masq_activating__animation"> | ||
| <video autoplay loop src="{{= window.location.origin }}/statics/images/masq/gifs/masq_loading.mp4"></video> |
There was a problem hiding this comment.
Using "origin" is incorrect here: the "baseUrl" ( /maps/...) is missing.
Actually an absolute path can directly be used in templates, since a <base> tag is defined in the html head:
Suggested change
| <video autoplay loop src="{{= window.location.origin }}/statics/images/masq/gifs/masq_loading.mp4"></video> | |
| <video autoplay loop src="/statics/images/masq/gifs/masq_loading.mp4"></video> |
sujeebant
force-pushed
the
masq-activation-modal
branch
from
a0a275c
to
4018f0b
Compare
sujeebant
force-pushed
the
masq-activation-modal
branch
from
4018f0b
to
3fb5a2d
Compare
amatissart
approved these changes
May 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.