This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
QMAPS-806 - Implemented the 'no results' panel #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
reviewed
May 15, 2019
| box-shadow: 0 0 4px 0 rgba(0, 0, 0, 0.16); | ||
| background-color: #ffffff; | ||
| display: flex; | ||
| flex-direction: column; |
There was a problem hiding this comment.
we need to be cautious when using "flex", as we want to support IE11. Could you check it works as expected ?
There was a problem hiding this comment.
@amatissart Sorry i couldn't successfully test it on ie11. I tried browserstack but it seems to give a false overview of the reality due to whatever reasons. I also tried adding certificates to ensure every network request doesn't fail but it doesn't seem to change anything.
I also would like to mention that some of my previous PRs included flexboxes and they've been merged without any discussions regarding ie11 support.
mlnor27
changed the title
amatissart
approved these changes
May 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.