This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
QMAPS-864 CSS fixes on PJ POI panel #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
suggested changes
Jun 26, 2019
|
|
||
| &:hover { | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| l |
GuillaumeGomez
previously requested changes
Jun 26, 2019
| } | ||
|
|
||
| .poi_panel__actions { | ||
| width: 110%; |
There was a problem hiding this comment.
That doesn't sounds like a good idea at all.
|
|
||
| .poi_panel__actions { | ||
| width: 110%; | ||
| margin-left: -5%; |
| color: $secondary_text; | ||
| text-transform: uppercase; | ||
| height: $HEADER_SIZE; | ||
| height: 40px; |
There was a problem hiding this comment.
The constant is here for a reason. :-/
| &:not(:first-child){ | ||
| min-width: 20% | ||
| } | ||
| min-width: 24%; |
There was a problem hiding this comment.
I'm a bit skeptical about those changes: why setting this value three times? Also: it'll need to be checked very carefully.
amatissart
approved these changes
Jul 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.