QMAPS-865 fix PJ phone numbers reveals #284
Conversation
|
Why did the package-lock changed?
|
src/panel/poi_panel.js
Outdated
| @@ -216,6 +216,11 @@ PoiPanel.prototype.emptyClickOnMap = function() { | |||
| } | |||
| }; | |||
|
|
|||
| PoiPanel.prototype.showPhone = function() { | |||
| document.querySelector(".poi_phone_container_hidden").style.display = "none" | |||
There was a problem hiding this comment.
Why not using the template system?
There was a problem hiding this comment.
You mean re-render all the template, just to show the number? It seemed overkill.
Also, in the category list, the phone number is revealed in the same way (CSS display none => block, and it seemed fine so I did the same)
There was a problem hiding this comment.
No, just part of the template which is much more maintainable than having to handle the DOM ourselves.
Yep, quite bad considering none of those changes have anything to do with your PR. |
|
You still have the lock file changes to remove. |
No description provided.