Qmaps 844 + QMAPS-845 add points anywhere on the map (+ panel with favorite / share / directions / categories buttons) #289
Conversation
xem
commented
Jul 10, 2019
•
xem
commented
…pt a poi), Initialize AnywherePanel (WIP)
…itinerary button, fix F5)
bin/middlewares/og_meta.js
Outdated
| const poiId = placeUrlMatch[1]; | ||
| poiId = placeUrlMatch[1]; | ||
| } | ||
| if (poiId && !poiId.startsWith('latlon:')) { |
There was a problem hiding this comment.
this change is no longer necessary, now that Idunn API can handle latlon: places
src/views/poi_panel.dot
Outdated
| {{= this.PoiBlocContainer.render(this.poi) }} | ||
|
|
||
| {{? this.poi.isFromOSM() }} | ||
| {{? isAnywherePoi || (this.poi.isFromOSM && this.poi.isFromOSM()) }} |
There was a problem hiding this comment.
this block should not be visible with anywhere POIs: OSM view and edit URLs are not defined for them
| width: 100px; | ||
| height: 100px; | ||
| width: 90px; | ||
| height: 90px; |
There was a problem hiding this comment.
do we really have to reduce the image size, that is already quite small ?
There was a problem hiding this comment.
🤷♂️ I don't even see the cases where it's used, so I don't have any opinion. Maybe we can simply revert this change for now to merge, and discuss every UI tweaks in a following PR.
There was a problem hiding this comment.
Thanks for the IRL explanation, so this is the illustration picture (most often photo) that exists for some POIs. I agree this is important, so I reverted it at 100px for now. 90dc60f
I'll probably change the layout of this component later so it doesn't depend on fixed height, so we don't have a big empty space when this photo doesn't exist.
