Add ESLint rule to use "const" instead of "let" where possible #296

bbecquet · 2019-07-16T08:19:31Z

Not sure it's a priority, but here is a linting proposition related to this comment

GuillaumeGomez · 2019-07-16T08:38:59Z

There is an error on CI.

bbecquet · 2019-07-16T08:43:58Z

@GuillaumeGomez should be ok now, something I had to change manually. Two variables declared on the same line, one const and one let. Maybe a case for https://eslint.org/docs/rules/one-var later :D

GuillaumeGomez · 2019-07-16T13:59:41Z

Hum. I think it needs a debate for the multiple variable declaration (I don't like it personally). But the current code is good so let's merge!

amatissart requested review from amatissart and removed request for amatissart July 16, 2019 08:22

bbecquet requested a review from GuillaumeGomez July 16, 2019 08:22

GuillaumeGomez previously approved these changes Jul 16, 2019

View reviewed changes

[ESLint] Add rule to enforce const when variable is not changed

dcc13ef

Doc: https://eslint.org/docs/rules/prefer-const

bbecquet dismissed GuillaumeGomez’s stale review via 9ad99eb July 16, 2019 08:29

bbecquet force-pushed the eslint-prefer-const branch from 3a9db2c to 9ad99eb Compare July 16, 2019 08:29

Run lint-fix after new prefer-const rule

63f0e38

bbecquet force-pushed the eslint-prefer-const branch from 9ad99eb to 63f0e38 Compare July 16, 2019 08:41

GuillaumeGomez approved these changes Jul 16, 2019

View reviewed changes

GuillaumeGomez merged commit 02ac2b3 into Qwant:master Jul 16, 2019

bbecquet deleted the eslint-prefer-const branch July 16, 2019 15:10

bbecquet mentioned this pull request Jul 18, 2019

Add ESLint rule to disallow 'var' #302

Merged

Provide feedback