This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Define stricter match for categories labels in suggestions #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
reviewed
Jul 24, 2019
amatissart
force-pushed
the
fix-category-suggest
branch
from
ddc15b0
to
c3eb7ee
Compare
bbecquet
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A category is returned in autocomplete suggestions if the user query matches the regex associated to the category, or its translated label.
This PR suggests to make this second check less permissive by requiring the query to start with the category label as a separate word (if there are enough letters in the query string).