Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Add custom HTTP headers to give picked suggestion ranking #313

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Add custom HTTP headers to give picked suggestion ranking #313

merged 2 commits into from
Aug 6, 2019

Conversation

GuillaumeGomez
Copy link
Contributor

No description provided.

bbecquet
bbecquet reviewed Jul 25, 2019
View reviewed changes
src/adapters/poi/idunn_poi.js Outdated Show resolved Hide resolved
src/adapters/poi/idunn_poi.js Outdated Show resolved Hide resolved
src/adapters/poi/idunn_poi.js Outdated Show resolved Hide resolved
src/adapters/suggest.js Outdated Show resolved Hide resolved
src/libs/ajax.js Show resolved Hide resolved
src/proxies/panel_manager.js Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the suggestion-ranking branch 2 times, most recently from 42dbd75 to dd68c0b Compare July 30, 2019 16:11
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 30, 2019
Merged
amatissart
amatissart reviewed Jul 30, 2019
View reviewed changes
src/adapters/poi/idunn_poi.js Outdated Show resolved Hide resolved
src/adapters/scene.js Outdated Show resolved Hide resolved
src/libs/ajax.js Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the suggestion-ranking branch 2 times, most recently from 0166ca0 to 49d04e8 Compare July 31, 2019 15:01
amatissart
amatissart suggested changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@amatissart amatissart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues to address.

src/adapters/poi/idunn_poi.js Show resolved Hide resolved
src/adapters/query_context.js Outdated Show resolved Hide resolved
src/libs/ajax.js Outdated Show resolved Hide resolved
src/adapters/query_context.js Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the suggestion-ranking branch 3 times, most recently from b4c6dfb to 8215b47 Compare August 5, 2019 10:50
@GuillaumeGomez
Copy link
Contributor Author

Updated.

@amatissart amatissart merged commit c47699f into Qwant:master Aug 6, 2019
@GuillaumeGomez GuillaumeGomez deleted the suggestion-ranking branch August 6, 2019 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amatissart amatissart amatissart approved these changes

@bbecquet bbecquet Awaiting requested review from bbecquet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @bbecquet @amatissart