This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
QMAPS-1005: fallback to tile POI when unknown by Idunn #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
changed the title
jbgriesner
approved these changes
Aug 20, 2019
amatissart
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the basic POI info from the tile feature to fill the POI panel when Idunn returned a 404 to the POI details request.
Also tries to clarify the flow of the
setPoimethod with better naming.Why
Some POI types are part of the tiles and clickable but not loaded in Idunn. Clicking on one of them returns to the default panel which is confusing.